add --x-package-warnings-prefix option to dartanalyzer

add --x-package-warnings-prefix option to dartanalyzer

This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.

Also added the number of source files analyzed and the number of
errors generated to performance report.

Cleanup: simplified code for triggering diet parsing.

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/9e21594c2aa7eedf09fd158ba9690233bfaf07e7

[skybrian, 2016-03-18 01:57:37]

skybrian@google.com changed reviewers:
+ brianwilkerson@google.com

[skybrian, 2016-03-18 01:57:38]

I'll add tests tomorrow if you're okay with this approach.

[Brian Wilkerson, 2016-03-18 14:13:18]

While I don't think this is the right long term approach, I'm fine with it as a
temporary solution.

> Removed dead code for reusing an analysis context. It looks like this could
only have happened when Driver.start() is called more than once, and nobody does
that as far as I can tell.

I believe that this code is used in batch mode, which is used by the test runner
(test.py), and that it significantly improves our performance there.

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:101: throw new StateError("start() can only
be called once");
Start *is* only called once, and it seems unlikely that anyone would make the
mistake of calling it again, so I don't understand the value of this check.

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/er...
File pkg/analyzer_cli/lib/src/error_formatter.dart (right):

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/er...
pkg/analyzer_cli/lib/src/error_formatter.dart:26: static int _inputErrorCount =
0;
This looks like it's duplicating some work that Phil recently did (and might not
be committed yet. You should coordinate with him on it.

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:291: 'Show warnings from package: imports
that match the given prefix')
Should be hidden because it's a temporary solution.

[skybrian, 2016-03-18 22:32:44]

Still need to write the tests.

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:101: throw new StateError("start() can only
be called once");
On 2016/03/18 14:13:17, Brian Wilkerson wrote:
> Start *is* only called once, and it seems unlikely that anyone would make the
> mistake of calling it again, so I don't understand the value of this check.

It's to make it easier for the next reader to tell that _analyzedFileCount is
calculated correctly.

Otherwise someone reading this code for the first time needs to look at the
usages to make sure that start() is indeed called only once. Since I did that
already, I thought it would be helpful to state the invariant explicitly.

In general, I think enforcing the invariants that you rely on makes code easier
to review. (Something I picked up from design by contract.)

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/er...
File pkg/analyzer_cli/lib/src/error_formatter.dart (right):

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/er...
pkg/analyzer_cli/lib/src/error_formatter.dart:26: static int _inputErrorCount =
0;
On 2016/03/18 14:13:17, Brian Wilkerson wrote:
> This looks like it's duplicating some work that Phil recently did (and might
not
> be committed yet. You should coordinate with him on it.

It's a slightly different statistic. Merged into AnalysisStats.

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/op...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/1806263004/diff/1/pkg/analyzer_cli/lib/src/op...
pkg/analyzer_cli/lib/src/options.dart:291: 'Show warnings from package: imports
that match the given prefix')
On 2016/03/18 14:13:17, Brian Wilkerson wrote:
> Should be hidden because it's a temporary solution.

Done

[skybrian, 2016-03-19 02:40:15]

skybrian@google.com changed reviewers:
+ paulberry@google.com

[skybrian, 2016-03-19 02:40:16]

Paul since Brian Wilkerson will be on vacation could you review this?

[skybrian, 2016-03-19 03:19:36]

Description was changed from

==========
add --x-package-warnings-prefix option to dartanalyzer

This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.

Also added the number of source files analyzed and the number of
errors generated to performance report.

Cleanups:

Removed dead code for reusing an analysis context.
It looks like this could only have happened when Driver.start()
is called more than once, and nobody does that as far as I can
tell.

Simplified code for triggering diet parsing.

BUG=
==========

to

==========
add --x-package-warnings-prefix option to dartanalyzer

This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.

Also added the number of source files analyzed and the number of
errors generated to performance report.

Cleanup: simplified code for triggering diet parsing.

BUG=
==========

[Paul Berry, 2016-03-21 17:26:33]

lgtm

[skybrian, 2016-03-21 18:37:02]

Description was changed from

==========
add --x-package-warnings-prefix option to dartanalyzer

This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.

Also added the number of source files analyzed and the number of
errors generated to performance report.

Cleanup: simplified code for triggering diet parsing.

BUG=
==========

to

==========
add --x-package-warnings-prefix option to dartanalyzer

This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.

Also added the number of source files analyzed and the number of
errors generated to performance report.

Cleanup: simplified code for triggering diet parsing.

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9e21594c2aa7eedf09fd158ba9690233bfaf07e7
==========

[skybrian, 2016-03-21 18:37:04]

Committed patchset #4 (id:60001) manually as
9e21594c2aa7eedf09fd158ba9690233bfaf07e7 (presubmit successful).