Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1806223002: CC Animation: Use bitset instead of unordered_set in LayerAnimationController (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, esprehn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Use bitset instead of unordered_set in LayerAnimationController A performance optimization. This avoids any heap allocations. BUG=595584 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b8634c4d77f7d4017bf69832ca191d09b7cf3ad3 Cr-Commit-Position: refs/heads/master@{#381850}

Patch Set 1 #

Patch Set 2 : Use operator[] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M cc/animation/layer_animation_controller.h View 3 chunks +5 lines, -2 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 1 3 chunks +26 lines, -16 lines 0 comments Download
M cc/animation/target_property.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
loyso (OOO)
4 years, 9 months ago (2016-03-17 06:06:30 UTC) #4
loyso (OOO)
Alternatively, we could use operator[]. It's more readable (if one thinks in key-value terms)
4 years, 9 months ago (2016-03-17 06:25:14 UTC) #6
ajuma
On 2016/03/17 06:25:14, loyso wrote: > Alternatively, we could use operator[]. It's more readable (if ...
4 years, 9 months ago (2016-03-17 13:25:13 UTC) #7
loyso (OOO)
On 2016/03/17 13:25:13, ajuma wrote: > On 2016/03/17 06:25:14, loyso wrote: > > Alternatively, we ...
4 years, 9 months ago (2016-03-17 22:55:17 UTC) #8
ajuma
Thanks, lgtm.
4 years, 9 months ago (2016-03-17 23:06:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806223002/20001
4 years, 9 months ago (2016-03-17 23:39:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 00:36:17 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:37:39 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8634c4d77f7d4017bf69832ca191d09b7cf3ad3
Cr-Commit-Position: refs/heads/master@{#381850}

Powered by Google App Engine
This is Rietveld 408576698