Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1806213002: Mention GN in the Linux build instructions documentation (Closed)

Created:
4 years, 9 months ago by alancutter (OOO until 2018)
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mention GN in the Linux build instructions documentation There's no pointers to what GN is or how to set it up from this document despite there being references to using it. This change adds the GN Quick Start Guide to the Advanced Features section. Committed: https://crrev.com/dff8eb21c3e4882bb0c522d83a46bb16d8a2643a Cr-Commit-Position: refs/heads/master@{#381666}

Patch Set 1 #

Total comments: 2

Patch Set 2 : / #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M docs/linux_build_instructions.md View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
alancutter (OOO until 2018)
4 years, 9 months ago (2016-03-17 05:33:41 UTC) #3
suzyh_UTC10 (ex-contributor)
Looks like one typo but otherwise lgtm https://codereview.chromium.org/1806213002/diff/1/docs/linux_build_instructions.md File docs/linux_build_instructions.md (right): https://codereview.chromium.org/1806213002/diff/1/docs/linux_build_instructions.md#newcode136 docs/linux_build_instructions.md:136: [GN Quick ...
4 years, 9 months ago (2016-03-17 05:42:30 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/1806213002/diff/1/docs/linux_build_instructions.md File docs/linux_build_instructions.md (right): https://codereview.chromium.org/1806213002/diff/1/docs/linux_build_instructions.md#newcode136 docs/linux_build_instructions.md:136: [GN Quick Start](..tools/gn/docs/quick_start.md) On 2016/03/17 at 05:42:30, suzyh wrote: ...
4 years, 9 months ago (2016-03-17 06:24:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806213002/20001
4 years, 9 months ago (2016-03-17 06:25:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 06:59:07 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 07:00:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dff8eb21c3e4882bb0c522d83a46bb16d8a2643a
Cr-Commit-Position: refs/heads/master@{#381666}

Powered by Google App Engine
This is Rietveld 408576698