Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 18062002: Make webkit test output comparison compatible to stress testing. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make webkit test output comparison compatible to stress testing. In stress testing, the output is repeated several times. In this case, it is now compared several times to the actual output. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15369

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reworked review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M test/webkit/testcfg.py View 1 1 chunk +33 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-06-27 12:34:44 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/18062002/diff/1/test/webkit/testcfg.py File test/webkit/testcfg.py (left): https://codereview.chromium.org/18062002/diff/1/test/webkit/testcfg.py#oldcode31 test/webkit/testcfg.py:31: nit: I liked this line, please keep it. ...
7 years, 5 months ago (2013-06-27 16:33:58 UTC) #2
Michael Achenbach
On 2013/06/27 16:33:58, Jakob wrote: > lgtm > > https://codereview.chromium.org/18062002/diff/1/test/webkit/testcfg.py > File test/webkit/testcfg.py (left): > ...
7 years, 5 months ago (2013-06-27 19:41:07 UTC) #3
Michael Achenbach
7 years, 5 months ago (2013-06-27 19:46:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698