Under the tab-modal signin flow, always show the Confirmation dialog.

Under the tab-modal signin flow, always show the Confirmation dialog.

BUG=588359, 585820
Committed: https://crrev.com/e5384bb8f5b574119cfd4764273687a15fa60cc4
Cr-Commit-Position: refs/heads/master@{#381965}

[anthonyvd, 2016-03-17 18:16:16]

anthonyvd@chromium.org changed reviewers:
+ rogerta@chromium.org

[anthonyvd, 2016-03-17 18:16:16]

Hi Roger, can you please take a look at this change?

From a product perspective we always want to display the sync confirmation
dialog, as opposed to before where some flows would lead to different outcomes.
It seems to me like this is the right thing to do and that we'll be able to
clean up some of the code around this change as a result of this when we phase
out the old flow.

Thanks!

[Roger Tawa OOO till Jul 10th, 2016-03-18 04:01:50]

lgtm

https://codereview.chromium.org/1806193003/diff/1/chrome/browser/ui/sync/one_...
File chrome/browser/ui/sync/one_click_signin_sync_starter.cc (right):

https://codereview.chromium.org/1806193003/diff/1/chrome/browser/ui/sync/one_...
chrome/browser/ui/sync/one_click_signin_sync_starter.cc:467: // be ran after the
modal is closed.
ran --> run

[anthonyvd, 2016-03-18 13:59:08]

https://codereview.chromium.org/1806193003/diff/1/chrome/browser/ui/sync/one_...
File chrome/browser/ui/sync/one_click_signin_sync_starter.cc (right):

https://codereview.chromium.org/1806193003/diff/1/chrome/browser/ui/sync/one_...
chrome/browser/ui/sync/one_click_signin_sync_starter.cc:467: // be ran after the
modal is closed.
On 2016/03/18 04:01:50, Roger Tawa wrote:
> ran --> run

Done.

[anthonyvd, 2016-03-18 13:59:11]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2016-03-18 13:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1806193003/#ps20001
(title: "Fix spelling")

[commit-bot: I haz the power, 2016-03-18 13:59:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806193003/20001

[commit-bot: I haz the power, 2016-03-18 14:46:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 14:47:14]

Description was changed from

==========
Under the tab-modal signin flow, always show the Confirmation dialog.

BUG=588359,585820
==========

to

==========
Under the tab-modal signin flow, always show the Confirmation dialog.

BUG=588359,585820

Committed: https://crrev.com/e5384bb8f5b574119cfd4764273687a15fa60cc4
Cr-Commit-Position: refs/heads/master@{#381965}
==========

[commit-bot: I haz the power, 2016-03-18 14:47:15]

Patchset 2 (id:??) landed as
https://crrev.com/e5384bb8f5b574119cfd4764273687a15fa60cc4
Cr-Commit-Position: refs/heads/master@{#381965}