Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1806153002: [Media Router] Add origins to sink query results. (Closed)

Created:
4 years, 9 months ago by imcheng
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router] Add origins to sink query results. Takes over https://codereview.chromium.org/1693963003/ Add |origins| to |OnSinksReceived| API from MRPM to MR. If |origins| is non-empty, then the result of sink query is only valid for those origins. Otherwise, the result is valid for all origins, which is the legacy behavior. The origin checking is done in base MediaSinksObserver class, which will call into the version of |OnSinksReceived| overridable by children classes. BUG=594858 Review URL: https://codereview.chromium.org/1784533004 Cr-Commit-Position: refs/heads/master@{#381332} (cherry picked from commit c9adbb1e8d955e1f658d92578ab5a51e4dbc8872) Committed: https://chromium.googlesource.com/chromium/src/+/80b7d507c5a3f96feaa0b09276ef80692ab421fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -102 lines) Patch
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router.mojom View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.cc View 5 chunks +28 lines, -10 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl_unittest.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M chrome/browser/media/router/media_sinks_observer.h View 3 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/media/router/media_sinks_observer.cc View 2 chunks +24 lines, -2 lines 0 comments Download
A chrome/browser/media/router/media_sinks_observer_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 6 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 4 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/media/router/test_helper.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media/router/test_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_media_router.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 3 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc View 10 chunks +27 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/media_router/media_router_e2e_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/media_router/test_media_sinks_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/media_router/test_media_sinks_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 9 months ago (2016-03-16 22:52:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80b7d507c5a3f96feaa0b09276ef80692ab421fe.

Powered by Google App Engine
This is Rietveld 408576698