Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/intersection-observer/timestamp.html

Issue 1806133002: IntersectionObserver: use an idle callback to send notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/timestamp-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/js-test.js"></script> 2 <script src="../resources/js-test.js"></script>
3 <script src="helper-functions.js"></script> 3 <script src="helper-functions.js"></script>
4 <div id="beforeFrame" style="width:100%; height:700px;"></div> 4 <div id="beforeFrame" style="width:100%; height:700px;"></div>
5 <div id="afterFrame" style="width:100%; height:700px;"></div> 5 <div id="afterFrame" style="width:100%; height:700px;"></div>
6 6
7 <script> 7 <script>
8 description("Test that intersection observer time is relative to time in the cal lback context."); 8 description("Test that intersection observer time is relative to time in the cal lback context.");
9 var topWindowEntries = []; 9 var topWindowEntries = [];
10 var iframeWindowEntries = []; 10 var iframeWindowEntries = [];
11 var topWindowObserver;
12 var iframeWindowObserver;
11 var targetIframe; 13 var targetIframe;
12 var iframeScroller; 14 var iframeScroller;
13 var topWindowTime; 15 var topWindowTime;
14 var iframeWindowTime; 16 var iframeWindowTime;
15 var timestampTolerance = 24; // 1.5 times frame duration. 17 // TODO(szager): We should be able to use a much smaller value for timestampTole rance
18 // by using testRunner.runIdleTasks after this patch lands:
19 // https://codereview.chromium.org/1806133002/
20 var timestampTolerance = 124; // ~= 100ms idle callback timeout + 1.5 * frame t ime
16 21
17 function step0() { 22 function step0() {
18 setTimeout(function() { 23 // Test results are only significant if there's a sufficient gap between
19 // Test results are only significant if there's a sufficient gap between 24 // top window time and iframe window time.
20 // top window time and iframe window time. 25 topWindowTime = performance.now();
21 topWindowTime = performance.now(); 26 iframeWindowTime = targetIframe.contentWindow.performance.now();
22 iframeWindowTime = targetIframe.contentWindow.performance.now(); 27 shouldBeGreaterThan("topWindowTime - iframeWindowTime", "2.5 * timestampTolera nce");
23 shouldBeGreaterThan("topWindowTime - iframeWindowTime", "2 * timestampTolera nce");
24 28
25 shouldBeEqualToNumber("topWindowEntries.length", 0); 29 topWindowEntries = topWindowEntries.concat(topWindowObserver.takeRecords());
26 shouldBeEqualToNumber("iframeWindowEntries.length", 0); 30 iframeWindowEntries = iframeWindowEntries.concat(iframeWindowObserver.takeReco rds());
27 document.scrollingElement.scrollTop = 200; 31 shouldBeEqualToNumber("topWindowEntries.length", 0);
28 iframeScroller.scrollTop = 250; 32 shouldBeEqualToNumber("iframeWindowEntries.length", 0);
29 requestAnimationFrame(step1); 33 document.scrollingElement.scrollTop = 200;
30 }); 34 iframeScroller.scrollTop = 250;
35 requestAnimationFrame(step1);
31 } 36 }
32 37
33 function step1() { 38 function step1() {
34 setTimeout(function() { 39 topWindowEntries = topWindowEntries.concat(topWindowObserver.takeRecords());
35 topWindowTime = performance.now(); 40 iframeWindowEntries = iframeWindowEntries.concat(iframeWindowObserver.takeReco rds());
36 iframeWindowTime = targetIframe.contentWindow.performance.now(); 41 topWindowTime = performance.now();
37 shouldBeEqualToNumber("topWindowEntries.length", 1); 42 iframeWindowTime = targetIframe.contentWindow.performance.now();
38 if (topWindowEntries.length) { 43 shouldBeEqualToNumber("topWindowEntries.length", 1);
39 shouldBeCloseTo("topWindowEntries[0].time", "topWindowTime", timestampTole rance); 44 if (topWindowEntries.length)
40 } 45 shouldBeCloseTo("topWindowEntries[0].time", "topWindowTime", timestampTolera nce);
41 shouldBeEqualToNumber("iframeWindowEntries.length", 1); 46
42 if (iframeWindowEntries.length) { 47 shouldBeEqualToNumber("iframeWindowEntries.length", 1);
43 shouldBeCloseTo("iframeWindowEntries[0].time", "iframeWindowTime", timesta mpTolerance); 48 if (iframeWindowEntries.length) {
44 } 49 shouldBeCloseTo("iframeWindowEntries[0].time", "iframeWindowTime", timestamp Tolerance);
45 finishJSTest(); 50 }
46 document.scrollingElement.scrollTop = 0; 51 finishJSTest();
47 }); 52 document.scrollingElement.scrollTop = 0;
48 } 53 }
49 54
50 function runTest() { 55 function runTest() {
51 var target = targetIframe.contentDocument.getElementById("target"); 56 var target = targetIframe.contentDocument.getElementById("target");
52 iframeScroller = targetIframe.contentDocument.scrollingElement; 57 iframeScroller = targetIframe.contentDocument.scrollingElement;
53 58
54 // Observer created here, callback created in iframe context. Timestamps shou ld be 59 // Observer created here, callback created in iframe context. Timestamps shou ld be
55 // from this window. 60 // from this window.
56 var observer = new IntersectionObserver(targetIframe.contentDocument.createObs erverCallback(topWindowEntries), {}); 61 topWindowObserver = new IntersectionObserver(targetIframe.contentDocument.crea teObserverCallback(topWindowEntries), {});
57 observer.observe(target); 62 topWindowObserver.observe(target);
58 63
59 // Callback created here, observer created in iframe. Timestamps should be 64 // Callback created here, observer created in iframe. Timestamps should be
60 // from iframe window. 65 // from iframe window.
61 observer = targetIframe.contentDocument.createObserver(function(newEntries) { 66 iframeWindowObserver = targetIframe.contentDocument.createObserver(function(ne wEntries) {
62 for (var i = 0; i < newEntries.length; i++) 67 for (var i = 0; i < newEntries.length; i++)
63 iframeWindowEntries.push(newEntries[i]); 68 iframeWindowEntries.push(newEntries[i]);
64 }); 69 });
65 observer.observe(target); 70 iframeWindowObserver.observe(target);
66 71
67 step0(); 72 // See README for explanation of double RAF.
73 requestAnimationFrame(() => { requestAnimationFrame(step0) });
68 } 74 }
69 75
70 window.onload = function() { 76 onload = function() {
71 setTimeout(function() { 77 setTimeout(function() {
72 targetIframe = document.createElement("iframe"); 78 targetIframe = document.createElement("iframe");
73 targetIframe.src = "../resources/intersection-observer-timestamp-subframe.ht ml"; 79 targetIframe.src = "../resources/intersection-observer-timestamp-subframe.ht ml";
74 targetIframe.style = "height: 100px; overflow-y: scroll"; 80 targetIframe.style = "height: 100px; overflow-y: scroll";
75 var afterFrame = document.getElementById("afterFrame"); 81 var afterFrame = document.getElementById("afterFrame");
76 afterFrame.parentNode.insertBefore(targetIframe, afterFrame); 82 afterFrame.parentNode.insertBefore(targetIframe, afterFrame);
77 targetIframe.onload = runTest; 83 targetIframe.onload = runTest;
78 }, 100); 84 }, 2.5 * timestampTolerance);
79 }; 85 };
80 86
81 </script> 87 </script>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/timestamp-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698