third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html - Issue 1806133002: IntersectionObserver: use an idle callback to send notifications.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html

Issue 1806133002: IntersectionObserver: use an idle callback to send notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/LeakExpectations ('k') | third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="/js-test-resources/js-test.js"></script>	2 <script src="/js-test-resources/js-test.js"></script>

3 <div style="width:100%; height:700px;"></div>	3 <div style="width:100%; height:700px;"></div>

4 <iframe id="target-iframe" src="http://localhost:8080/intersection-observer/reso urces/cross-origin-subframe.html" style="height: 100px; overflow-y: scroll"></if rame>	4 <iframe id="target-iframe" src="http://localhost:8080/intersection-observer/reso urces/cross-origin-subframe.html" style="height: 100px; overflow-y: scroll"></if rame>

5 <div style="width:100%; height:700px;"></div>	5 <div style="width:100%; height:700px;"></div>

6	6

7 <script>	7 <script>

8 setPrintTestResultsLazily();	8 setPrintTestResultsLazily();

9 self.jsTestIsAsync = true;	9 self.jsTestIsAsync = true;

10	10

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 }	46 }

47 }	47 }

48	48

49 function handleMessage(event) {	49 function handleMessage(event) {

50 if (event.data.hasOwnProperty('scrollTo')) {	50 if (event.data.hasOwnProperty('scrollTo')) {

51 document.scrollingElement.scrollTop = event.data.scrollTo;	51 document.scrollingElement.scrollTop = event.data.scrollTo;

52 requestAnimationFrame(function () { iframe.contentWindow.postMessage("", "*" ) });	52 requestAnimationFrame(function () { iframe.contentWindow.postMessage("", "*" ) });

53 } else if (event.data.hasOwnProperty('actual')) {	53 } else if (event.data.hasOwnProperty('actual')) {

54 checkData(event.data.actual, event.data.expected);	54 checkData(event.data.actual, event.data.expected);

55 } else if (event.data.hasOwnProperty('DONE')) {	55 } else if (event.data.hasOwnProperty('DONE')) {

56 finishJSTest();	56 // Allow time for pending idle tasks to finish to prevent leaks.

	57 setTimeout(finishJSTest, 150);
	sof 2016/03/17 07:14:58 Do you need this with the leak exemptions and once Do you need this with the leak exemptions and once the fix for 595155 lands? For this & all other instances of it in this CL. szager1 2016/03/17 17:43:22 The fix for 595155 will make it possible to remove Show quoted text On 2016/03/17 07:14:58, sof wrote: > Do you need this with the leak exemptions and once the fix for 595155 lands? For > this & all other instances of it in this CL. The fix for 595155 will make it possible to remove the lines from LayoutTests/LeakExpectations, but only if the tests continue to use setTimeout here. To avoid leaking, the test code must be certain that all idle tasks have completed before exiting. Issue 595152 shows that the idle tasks scheduled by IntersectionObserver will only run when their 100ms timeout expires, hence the slightly conservative 150ms timeout here. And even were 595152 fixed, we'd probably still need a setTimeout here, because there's no programmatic way to ascertain whether the idle task actually ran. ojan 2016/03/17 17:48:03 Can you instead add a callback to the Intersection Show quoted text On 2016/03/17 at 17:43:22, szager1 wrote: > On 2016/03/17 07:14:58, sof wrote: > > Do you need this with the leak exemptions and once the fix for 595155 lands? For > > this & all other instances of it in this CL. > > The fix for 595155 will make it possible to remove the lines from LayoutTests/LeakExpectations, but only if the tests continue to use setTimeout here. To avoid leaking, the test code must be certain that all idle tasks have completed before exiting. > > Issue 595152 shows that the idle tasks scheduled by IntersectionObserver will only run when their 100ms timeout expires, hence the slightly conservative 150ms timeout here. And even were 595152 fixed, we'd probably still need a setTimeout here, because there's no programmatic way to ascertain whether the idle task actually ran. Can you instead add a callback to the IntersectionObserver and finishJSTest inside the callback?
57 document.scrollingElement.scrollTop = 0;	58 document.scrollingElement.scrollTop = 0;

58 } else {	59 } else {

59 requestAnimationFrame(function () { iframe.contentWindow.postMessage("", "*" ) });	60 requestAnimationFrame(function () { iframe.contentWindow.postMessage("", "*" ) });

60 }	61 }

61 }	62 }

62	63

63 window.addEventListener("message", handleMessage);	64 window.addEventListener("message", handleMessage);

	65

64 iframe.onload = function() {	66 iframe.onload = function() {

65 iframe.contentWindow.postMessage("", "*")	67 // See LayoutTests/intersection-observer/README for explanation of double RAF.

66 };	68 requestAnimationFrame(() => {

	69 requestAnimationFrame(() => { iframe.contentWindow.postMessage("", "*") })

	70 });

	71 }

67 </script>	72 </script>

OLD	NEW