Issue 1806083002: Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5 consecutive RTOs. …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1806083002: Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5 consecutive RTOs. … (Closed)

Created:
4 years, 9 months ago by fnk

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett

Base URL:
https://chromium.googlesource.com/chromium/src.git@116677107

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5 consecutive RTOs. Protected by quic_enable_rto_timeout. Merge internal change: 116687954 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -0 lines)			Patch
M	net/quic/crypto/crypto_protocol.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_connection.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+4 lines, -0 lines	1 comment	Download

Depends on Patchset:

Issue 1814483002 Patch 1

Dependent Patchsets:

Issue 1808863002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 9 months ago (2016-03-16 20:27:55 UTC) #2

https://codereview.chromium.org/1806083002/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/1806083002/diff/1/net/quic/quic_flags.cc#newc...
net/quic/quic_flags.cc:140: bool FLAGS_quic_enable_rto_timeout = false;
I think we normally default new flags to true when we merge to chrome

Expand Messages | Collapse Messages