Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1806063002: [parser] report illegal token error in ParseMemberExpressionContinuation() (Closed)

Created:
4 years, 9 months ago by caitp (gmail)
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] report illegal token error in ParseMemberExpressionContinuation() Report correct error message when a scanner error occurs while parsing a tagged template within an expression context. BUG=v8:4829, v8:3230 LOG=N R=adamk@chromium.org, littledan@chromium.org Committed: https://crrev.com/14188ea07f80ada5035431a6745b0b27bcbcd7ad Cr-Commit-Position: refs/heads/master@{#34839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M src/parsing/parser-base.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A + test/message/regress/regress-4829-1.js View 1 chunk +3 lines, -4 lines 0 comments Download
A + test/message/regress/regress-4829-1.out View 1 chunk +4 lines, -3 lines 0 comments Download
A + test/message/regress/regress-4829-2.js View 1 chunk +3 lines, -4 lines 0 comments Download
A + test/message/regress/regress-4829-2.out View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp (gmail)
Please take a quick look
4 years, 9 months ago (2016-03-16 18:33:37 UTC) #1
adamk
lgtm
4 years, 9 months ago (2016-03-16 18:46:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806063002/1
4 years, 9 months ago (2016-03-16 20:00:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:25:34 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:26:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14188ea07f80ada5035431a6745b0b27bcbcd7ad
Cr-Commit-Position: refs/heads/master@{#34839}

Powered by Google App Engine
This is Rietveld 408576698