Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 1806023002: [Telemetry] Re-add API to tear down state after each story run (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/page/shared_page_state.py
diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py
index 3c0e07d094df069ebce239f151dbb60587d8ca50..0f8cbe4e0347b07e014dccc4e583ac8ae15dfca5 100644
--- a/telemetry/telemetry/page/shared_page_state.py
+++ b/telemetry/telemetry/page/shared_page_state.py
@@ -229,7 +229,13 @@ class SharedPageState(story.SharedState):
page_set = page.page_set
self._current_page = page
- if self._test.RestartBrowserBeforeEachPage() or page.startup_url:
+ if self._browser and (self._test.RestartBrowserBeforeEachPage()
+ or page.startup_url):
+ assert not self.platform.tracing_controller.is_tracing_running, (
+ 'Should not restart browser when tracing is already running. For '
+ 'TimelineBasedMeasurement (TBM) benchmarks, you should not use '
+ 'startup_url. Use benchmark.ShouldTearDownStateAfterEachStoryRun '
+ 'instead.')
self._StopBrowser()
started_browser = not self.browser

Powered by Google App Engine
This is Rietveld 408576698