Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1805923006: Instrument EDK sync Broker initialization (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrument EDK sync Broker initialization Bringing up Mojo at process startup caused a regression on OS X renderer startup times. At least half of the regression seems to be attributable to blocking on getting the parent pipe handle from the sync broker channel. We can eliminate this behavior on OS X now that we're using Mach shm, but let's also make sure it's not causing problems elsewhere in the wild. BUG=591742 Committed: https://crrev.com/c326671407f8790fbb7ee14ca59ac37aa25afa87 Cr-Commit-Position: refs/heads/master@{#381953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M mojo/edk/system/node_controller.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ken Rockot(use gerrit already)
PTAL! amistry for mojo, isherman for histograms. Thanks
4 years, 9 months ago (2016-03-18 04:54:39 UTC) #2
Ilya Sherman
metrics lgtm
4 years, 9 months ago (2016-03-18 04:56:22 UTC) #3
Anand Mistry (off Chromium)
lgtm
4 years, 9 months ago (2016-03-18 05:35:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805923006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805923006/1
4 years, 9 months ago (2016-03-18 05:58:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/191022)
4 years, 9 months ago (2016-03-18 07:05:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805923006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805923006/1
4 years, 9 months ago (2016-03-18 13:15:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 13:50:45 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 13:52:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c326671407f8790fbb7ee14ca59ac37aa25afa87
Cr-Commit-Position: refs/heads/master@{#381953}

Powered by Google App Engine
This is Rietveld 408576698