Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1805923003: Remove auto_login_parser from chrome deps (Closed)

Created:
4 years, 9 months ago by boliu
Modified:
4 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove auto_login_parser from chrome deps //src/chrome code have not used auto_login_parser since r344922 ~half a year ago. Remove the dependency. BUG= Committed: https://crrev.com/69537781dd7db6aa18d40fad90e3a6b4d2c4f1cc Cr-Commit-Position: refs/heads/master@{#381703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805923003/1
4 years, 9 months ago (2016-03-16 21:58:10 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-16 21:58:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805923003/1
4 years, 9 months ago (2016-03-16 21:58:51 UTC) #6
boliu
ptal
4 years, 9 months ago (2016-03-16 22:43:08 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 22:51:57 UTC) #10
Peter Kasting
LGTM
4 years, 9 months ago (2016-03-17 06:03:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805923003/1
4 years, 9 months ago (2016-03-17 14:15:17 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 14:19:43 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 14:21:25 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69537781dd7db6aa18d40fad90e3a6b4d2c4f1cc
Cr-Commit-Position: refs/heads/master@{#381703}

Powered by Google App Engine
This is Rietveld 408576698