Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1805913002: skip stroke outset of all teeny lines (Closed)

Created:
4 years, 9 months ago by caryclark
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skip stroke outset of all teeny lines Allow a small amount of slop when seeing if the previous moveTo and subsequent lineTo are the same. R=robertphillips@google.com BUG=593049 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1805913002 Committed: https://skia.googlesource.com/skia/+/1b6934fcd968cf7e2d931bea3eefcd05a168ec3d

Patch Set 1 #

Patch Set 2 : simplify example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M gm/arcto.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805913002/20001
4 years, 9 months ago (2016-03-16 13:10:10 UTC) #3
caryclark
4 years, 9 months ago (2016-03-16 13:10:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 13:27:22 UTC) #6
caryclark
Pleasantly, this doesn't affect any Gold output other than the newly added test.
4 years, 9 months ago (2016-03-16 13:44:11 UTC) #7
robertphillips
lgtm
4 years, 9 months ago (2016-03-16 13:45:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805913002/20001
4 years, 9 months ago (2016-03-16 13:45:55 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 13:46:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1b6934fcd968cf7e2d931bea3eefcd05a168ec3d

Powered by Google App Engine
This is Rietveld 408576698