src/isolate.cc - Issue 1805903002: [serializer] Add API to warm up startup snapshot with an additional script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 1805903002: [serializer] Add API to warm up startup snapshot with an additional script. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index b7665d749d5ac7074656709604d3a1fba11c8399..653f8b65ee618564618932e642ba6b66772ce4ba 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -2228,7 +2228,7 @@ bool Isolate::Init(Deserializer* des) {

}

if (create_heap_objects) {

- // Terminate the cache array with the sentinel so we can iterate.

+ // Terminate the partial snapshot cache so we can iterate.

partial_snapshot_cache_.Add(heap_.undefined_value());

}

« no previous file with comments | « src/isolate.h ('k') | src/snapshot/deserializer.cc » ('j') | no next file with comments »