third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('K') | « third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py ('k') | third_party/WebKit/Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index c717e7cd759e85018a7e2f55a12d29d840ce897b..10f615b931629bc05cb3fedeee5a4bdfbff08a84 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -120,6 +120,9 @@ def interface_context(interface):

is_global = ('PrimaryGlobal' in extended_attributes or

'Global' in extended_attributes)

+ # [RequiresFinalizer]

+ requires_finalizer = 'RequiresFinalizer' in extended_attributes

# [SetWrapperReferenceFrom]

set_wrapper_reference_from = extended_attributes.get('SetWrapperReferenceFrom')

if set_wrapper_reference_from:

@@ -192,6 +195,7 @@ def interface_context(interface):

'pass_cpp_type': cpp_template_type(

cpp_ptr_type('PassRefPtr', 'RawPtr', this_gc_type),

cpp_name(interface)),

+ 'requires_finalizer': requires_finalizer,

'runtime_enabled_function': runtime_enabled_function_name(interface), # [RuntimeEnabled]

'set_wrapper_reference_from': set_wrapper_reference_from,

'set_wrapper_reference_to': set_wrapper_reference_to,