third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

index 6fc72df6aa853d0055ef1ea189c0343943d0a9f0..ec22755be8646ad22a3ba7ab1840f8a9bba92ef7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

@@ -151,8 +151,6 @@ public:

bool containsWrapper() const { return !m_wrapper.IsEmpty(); }

- virtual bool hasPendingActivity() const;

#if !ENABLE(OILPAN)

protected:

virtual ~ScriptWrappable()