third_party/WebKit/Source/modules/notifications/Notification.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCRoot.cpp ('K') | « third_party/WebKit/Source/modules/netinfo/NetworkInformation.h ('k') | third_party/WebKit/Source/modules/permissions/PermissionStatus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index 065e3b9e6d4eca12c49c79dc7cdd9630cdbd6e10..c8199637d836bd18b7df831235edfb2dd933ac1f 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -34,6 +34,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptValue.h"

#include "bindings/core/v8/SerializedScriptValue.h"

+#include "bindings/core/v8/V8GCRoot.h"

#include "core/dom/ActiveDOMObject.h"

#include "core/dom/DOMTimeStamp.h"

#include "modules/EventTargetModules.h"

@@ -57,7 +58,7 @@ class NotificationOptions;

class NotificationPermissionCallback;

class ScriptState;

-class MODULES_EXPORT Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate {

+class MODULES_EXPORT Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate, public V8GCRoot {

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(Notification);

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Notification);

DEFINE_WRAPPERTYPEINFO();