third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCRoot.cpp ('K') | « third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h ('k') | third_party/WebKit/Source/modules/fetch/Body.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h

index bd6c4f1a006947250b1e3cbced37efa797ab62b9..ab690a96f13093cc015e3262bede0a40ce63922b 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h

+++ b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h

@@ -28,6 +28,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptWrappable.h"

+#include "bindings/core/v8/V8GCRoot.h"

#include "core/dom/ActiveDOMObject.h"

#include "core/dom/DOMArrayPiece.h"

#include "platform/Timer.h"

@@ -49,7 +50,7 @@ class WebContentDecryptionModule;

// References are held by JS and HTMLMediaElement.

// The WebContentDecryptionModule has the same lifetime as this object.

-class MediaKeys : public GarbageCollectedFinalized<MediaKeys>, public ActiveDOMObject, public ScriptWrappable {

+class MediaKeys : public GarbageCollectedFinalized<MediaKeys>, public ActiveDOMObject, public ScriptWrappable, public V8GCRoot {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaKeys);

DEFINE_WRAPPERTYPEINFO();

public: