third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCRoot.cpp ('K') | « third_party/WebKit/Source/core/workers/SharedWorker.h ('k') | third_party/WebKit/Source/modules/battery/BatteryManager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

index 32518c964d01bfebfebdfb1bc8c0db19c39cabfc..5e134bd6881e48a13f016e47b0da2b7c4633c54d 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

@@ -24,6 +24,7 @@

#include "bindings/core/v8/ScriptString.h"

#include "bindings/core/v8/ScriptWrappable.h"

+#include "bindings/core/v8/V8GCRoot.h"

#include "core/dom/ActiveDOMObject.h"

#include "core/dom/DocumentParserClient.h"

#include "core/loader/ThreadableLoaderClient.h"

@@ -66,7 +67,7 @@ class XMLHttpRequestUpload;

typedef int ExceptionCode;

-class XMLHttpRequest final : public XMLHttpRequestEventTarget, private ThreadableLoaderClient, public DocumentParserClient, public ActiveDOMObject {

+class XMLHttpRequest final : public XMLHttpRequestEventTarget, private ThreadableLoaderClient, public DocumentParserClient, public ActiveDOMObject, public V8GCRoot {

DEFINE_WRAPPERTYPEINFO();

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(XMLHttpRequest);

public: