third_party/WebKit/Source/core/streams/ReadableStreamReader.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamReader.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCRoot.cpp ('K') | « third_party/WebKit/Source/core/page/EventSource.h ('k') | third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/streams/ReadableStreamReader.h

diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamReader.h b/third_party/WebKit/Source/core/streams/ReadableStreamReader.h

index d743af1391064600ae29bb211be28bd52bc69fba..7eb9fab9f20b51fc3cc94a2da062a8fb92267a32 100644

--- a/third_party/WebKit/Source/core/streams/ReadableStreamReader.h

+++ b/third_party/WebKit/Source/core/streams/ReadableStreamReader.h

@@ -10,6 +10,7 @@

#include "bindings/core/v8/ScriptValue.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "bindings/core/v8/ToV8.h"

+#include "bindings/core/v8/V8GCRoot.h"

#include "core/CoreExport.h"

#include "core/dom/ContextLifecycleObserver.h"

#include "core/streams/ReadableStream.h"

@@ -24,7 +25,7 @@ class ScriptState;

// ReadableStreamReader corresponds to the same-name class in the Streams spec

// https://streams.spec.whatwg.org/.

-class CORE_EXPORT ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ContextLifecycleObserver {

+class CORE_EXPORT ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ContextLifecycleObserver, public V8GCRoot {

DEFINE_WRAPPERTYPEINFO();

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ReadableStreamReader);

public: