Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIPort.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webmidi/MIDIPort.h
diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIPort.h b/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
index e67c069d7e72eee589ef37bfc0d035a769985659..ce1806032ade44d769f9eea7ee16c5c88ecd1175 100644
--- a/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
+++ b/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
@@ -31,6 +31,7 @@
#ifndef MIDIPort_h
#define MIDIPort_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/dom/ExceptionCode.h"
@@ -42,7 +43,7 @@ namespace blink {
class MIDIAccess;
-class MIDIPort : public RefCountedGarbageCollectedEventTargetWithInlineData<MIDIPort>, public ActiveDOMObject {
+class MIDIPort : public RefCountedGarbageCollectedEventTargetWithInlineData<MIDIPort>, public ActiveScriptWrappable, public ActiveDOMObject {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MIDIPort);
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MIDIPort);
@@ -84,8 +85,10 @@ public:
const AtomicString& interfaceName() const override { return EventTargetNames::MIDIPort; }
ExecutionContext* getExecutionContext() const final;
+ // ActiveScriptWrappable
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject
- bool hasPendingActivity() const override;
void stop() override;
protected:

Powered by Google App Engine
This is Rietveld 408576698