Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h b/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
index b7e78cff29e02efae952ede8e44d830070c2d559..d3134d5cf62c453a9e269e5cf6f06fd266f35c0c 100644
--- a/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
+++ b/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
@@ -31,6 +31,7 @@
#ifndef MIDIAccess_h
#define MIDIAccess_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "core/dom/ActiveDOMObject.h"
#include "modules/EventTargetModules.h"
@@ -48,7 +49,7 @@ class MIDIInputMap;
class MIDIOutput;
class MIDIOutputMap;
-class MIDIAccess final : public RefCountedGarbageCollectedEventTargetWithInlineData<MIDIAccess>, public ActiveDOMObject, public MIDIAccessorClient {
+class MIDIAccess final : public RefCountedGarbageCollectedEventTargetWithInlineData<MIDIAccess>, public ActiveScriptWrappable, public ActiveDOMObject, public MIDIAccessorClient {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MIDIAccess);
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MIDIAccess);
@@ -73,8 +74,10 @@ public:
const AtomicString& interfaceName() const override { return EventTargetNames::MIDIAccess; }
ExecutionContext* getExecutionContext() const override { return ActiveDOMObject::getExecutionContext(); }
+ // ActiveScriptWrappable
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject
- bool hasPendingActivity() const override;
void stop() override;
// MIDIAccessorClient

Powered by Google App Engine
This is Rietveld 408576698