third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl ('k') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h b/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

index d86dc08633ebe65eb9dfee2223fed6b3ccaf1662..8adb2d0ff3304bc9fbe0d967b555c53388ea5f14 100644

--- a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h

@@ -26,6 +26,7 @@

#define ScriptProcessorNode_h

#include "base/gtest_prod_util.h"

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "modules/webaudio/AudioNode.h"

#include "platform/audio/AudioBus.h"

#include "wtf/Forward.h"

@@ -90,7 +91,7 @@ private:

FRIEND_TEST_ALL_PREFIXES(ScriptProcessorNodeTest, BufferLifetime);

};

-class ScriptProcessorNode final : public AudioNode {

+class ScriptProcessorNode final : public AudioNode, public ActiveScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

// bufferSize must be one of the following values: 256, 512, 1024, 2048,

@@ -106,7 +107,7 @@ public:

DEFINE_ATTRIBUTE_EVENT_LISTENER(audioprocess);

size_t bufferSize() const;

- // ScriptWrappable

+ // ActiveScriptWrappable

bool hasPendingActivity() const final;

private: