third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AudioContext.idl ('k') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

index ff5f9ef4f16bdcf302e66df6fdca0fffa27699d9..4be86da99264e3945411e72cc2ea0f91194252c4 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

@@ -29,6 +29,7 @@

#ifndef AudioScheduledSourceNode_h

#define AudioScheduledSourceNode_h

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "modules/webaudio/AudioSourceNode.h"

namespace blink {

@@ -120,7 +121,7 @@ private:

int m_playbackState;

};

-class AudioScheduledSourceNode : public AudioSourceNode {

+class AudioScheduledSourceNode : public AudioSourceNode, public ActiveScriptWrappable {

public:

void start(ExceptionState&);

void start(double when, ExceptionState&);

@@ -130,7 +131,7 @@ public:

EventListener* onended();

void setOnended(PassRefPtrWillBeRawPtr<EventListener>);

- // ScriptWrappable

+ // ActiveScriptWrappable

bool hasPendingActivity() const final;

protected: