Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
index ee3a493f71292382bff2216427cb75e92b259eeb..dfa6e670c3d142c61b9fdadb3ccf819dbb3b1fb8 100644
--- a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
+++ b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
@@ -25,6 +25,7 @@
#ifndef AbstractAudioContext_h
#define AbstractAudioContext_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "core/dom/ActiveDOMObject.h"
@@ -81,7 +82,7 @@ class WaveShaperNode;
// AbstractAudioContext is the cornerstone of the web audio API and all AudioNodes are created from it.
// For thread safety between the audio thread and the main thread, it has a rendering graph locking mechanism.
-class MODULES_EXPORT AbstractAudioContext : public RefCountedGarbageCollectedEventTargetWithInlineData<AbstractAudioContext>, public ActiveDOMObject {
+class MODULES_EXPORT AbstractAudioContext : public RefCountedGarbageCollectedEventTargetWithInlineData<AbstractAudioContext>, public ActiveScriptWrappable, public ActiveDOMObject {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(AbstractAudioContext);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(AbstractAudioContext);
DEFINE_WRAPPERTYPEINFO();
@@ -112,7 +113,7 @@ public:
// Document notification
void stop() final;
- bool hasPendingActivity() const override;
+ bool hasPendingActivity() const final;
AudioDestinationNode* destination() const { return m_destinationNode.get(); }

Powered by Google App Engine
This is Rietveld 408576698