Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechRecognition.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/speech/SpeechRecognition.h
diff --git a/third_party/WebKit/Source/modules/speech/SpeechRecognition.h b/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
index a216bbf83f57f60e8d6d8325a89ec1e7d33a5d29..17d8323e7a6fe111d176e6c4bcd1f0c5c1ae7c77 100644
--- a/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
+++ b/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
@@ -26,6 +26,7 @@
#ifndef SpeechRecognition_h
#define SpeechRecognition_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/page/PageLifecycleObserver.h"
#include "modules/EventTargetModules.h"
@@ -45,7 +46,7 @@ class MediaStreamTrack;
class SpeechRecognitionController;
class SpeechRecognitionError;
-class MODULES_EXPORT SpeechRecognition final : public RefCountedGarbageCollectedEventTargetWithInlineData<SpeechRecognition>, public PageLifecycleObserver, public ActiveDOMObject {
+class MODULES_EXPORT SpeechRecognition final : public RefCountedGarbageCollectedEventTargetWithInlineData<SpeechRecognition>, public PageLifecycleObserver, public ActiveScriptWrappable, public ActiveDOMObject {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(SpeechRecognition);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechRecognition);
DEFINE_WRAPPERTYPEINFO();
@@ -90,8 +91,10 @@ public:
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override;
+ // ActiveScriptWrappable.
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject.
- bool hasPendingActivity() const override;
void stop() override;
DEFINE_ATTRIBUTE_EVENT_LISTENER(audiostart);

Powered by Google App Engine
This is Rietveld 408576698