third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

index 0f23f8feff059fe90c00f4663caa4013344078f7..53aa5c931f75182c508a61ab1787e80dd1b632e7 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

@@ -98,7 +98,8 @@ ScriptPromise ServiceWorkerRegistration::unregister(ScriptState* scriptState)

}

ServiceWorkerRegistration::ServiceWorkerRegistration(ExecutionContext* executionContext, PassOwnPtr<WebServiceWorkerRegistration::Handle> handle)

- : ActiveDOMObject(executionContext)

+ : ActiveScriptWrappable(this)

+ , ActiveDOMObject(executionContext)

, m_handle(handle)

, m_provider(nullptr)

, m_stopped(false)