Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
index ee1325fddca1f91f9d248ddf9de501de814df3f4..7b37c77e30a8721bc72c044b76e34c11204e68df 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
@@ -31,6 +31,7 @@
#ifndef ServiceWorker_h
#define ServiceWorker_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/SerializedScriptValue.h"
#include "core/workers/AbstractWorker.h"
@@ -45,7 +46,7 @@ namespace blink {
class ScriptPromiseResolver;
-class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public WebServiceWorkerProxy {
+class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public ActiveScriptWrappable, public WebServiceWorkerProxy {
DEFINE_WRAPPERTYPEINFO();
public:
static ServiceWorker* from(ExecutionContext*, PassOwnPtr<WebServiceWorker::Handle>);
@@ -75,8 +76,10 @@ private:
static ServiceWorker* getOrCreate(ExecutionContext*, PassOwnPtr<WebServiceWorker::Handle>);
ServiceWorker(ExecutionContext*, PassOwnPtr<WebServiceWorker::Handle>);
+ // ActiveScriptWrappable overrides.
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject overrides.
- bool hasPendingActivity() const override;
void stop() override;
// A handle to the service worker representation in the embedder.

Powered by Google App Engine
This is Rietveld 408576698