Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
index 06e454e81c07052e654f7bc447ebef9648760e10..5c6c1e4c2e9da9431fda69b2139b65e05a924fb6 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
+++ b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
@@ -5,6 +5,7 @@
#ifndef PresentationAvailability_h
#define PresentationAvailability_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "core/page/PageLifecycleObserver.h"
@@ -24,6 +25,7 @@ class ScriptPromiseResolver;
// change. The object will only listen to changes when required.
class MODULES_EXPORT PresentationAvailability final
: public RefCountedGarbageCollectedEventTargetWithInlineData<PresentationAvailability>
+ , public ActiveScriptWrappable
, public ActiveDOMObject
, public PageLifecycleObserver
, public WebPresentationAvailabilityObserver {
@@ -42,8 +44,10 @@ public:
void availabilityChanged(bool) override;
const WebURL url() const override;
+ // ActiveScriptWrappable implementation.
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject implementation.
- bool hasPendingActivity() const override;
void suspend() override;
void resume() override;
void stop() override;

Powered by Google App Engine
This is Rietveld 408576698