Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.h
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
index ba88e2fc7fb8ec86c8ddf6621c0982f58c6fd39b..5ac62c70b51c807686198e034662b455c9e6928e 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
@@ -5,6 +5,7 @@
#ifndef PermissionStatus_h
#define PermissionStatus_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "platform/heap/Handle.h"
@@ -23,6 +24,7 @@ class ScriptPromiseResolver;
// ExecutionContext.
class PermissionStatus final
: public RefCountedGarbageCollectedEventTargetWithInlineData<PermissionStatus>
+ , public ActiveScriptWrappable
, public ActiveDOMObject
, public WebPermissionObserver {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(PermissionStatus);
@@ -41,8 +43,10 @@ public:
// WebPermissionObserver implementation.
void permissionChanged(WebPermissionType, WebPermissionStatus) override;
+ // ActiveScriptWrappable implementation.
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject implementation.
- bool hasPendingActivity() const override;
void suspend() override;
void resume() override;
void stop() override;

Powered by Google App Engine
This is Rietveld 408576698