Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.h
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h
index 68af8e1882702511e61918f00048e58c2096eb5c..0b9295a0c5aa76d347e32e9503d9834f4355a95d 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.h
+++ b/third_party/WebKit/Source/modules/notifications/Notification.h
@@ -31,6 +31,7 @@
#ifndef Notification_h
#define Notification_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/SerializedScriptValue.h"
@@ -57,7 +58,7 @@ class NotificationOptions;
class NotificationPermissionCallback;
class ScriptState;
-class MODULES_EXPORT Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate {
+class MODULES_EXPORT Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveScriptWrappable, public ActiveDOMObject, public WebNotificationDelegate {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(Notification);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Notification);
DEFINE_WRAPPERTYPEINFO();
@@ -113,7 +114,9 @@ public:
// ActiveDOMObject interface.
void stop() override;
- bool hasPendingActivity() const override;
+
+ // ActiveScriptWrappable interface.
+ bool hasPendingActivity() const final;
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698