Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/modules/netinfo/NetworkInformation.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
diff --git a/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h b/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
index 0090c5eb1bd70d773a27e4b405225b9fc9dedbd7..07765526b506e7e6a17cba216511d0a66b7e8a78 100644
--- a/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
+++ b/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
@@ -5,6 +5,7 @@
#ifndef NetworkInformation_h
#define NetworkInformation_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "core/page/NetworkStateNotifier.h"
@@ -16,6 +17,7 @@ class ExecutionContext;
class NetworkInformation final
: public RefCountedGarbageCollectedEventTargetWithInlineData<NetworkInformation>
+ , public ActiveScriptWrappable
, public ActiveDOMObject
, public NetworkStateNotifier::NetworkStateObserver {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(NetworkInformation);
@@ -36,8 +38,10 @@ public:
ExecutionContext* getExecutionContext() const override;
void removeAllEventListeners() override;
+ // ActiveScriptWrappable
+ bool hasPendingActivity() const final;
+
// ActiveDOMObject overrides.
- bool hasPendingActivity() const override;
void stop() override;
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698