Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h
index da9ff7518cb09b2485eedadd33c4749398b68d2e..66120bfa60cb6f6ab2ca90d55c5544d538773fc1 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h
+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h
@@ -31,6 +31,7 @@
#ifndef RTCPeerConnection_h
#define RTCPeerConnection_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "core/dom/ActiveDOMObject.h"
@@ -63,6 +64,7 @@ class VoidCallback;
class RTCPeerConnection final
: public RefCountedGarbageCollectedEventTargetWithInlineData<RTCPeerConnection>
, public WebRTCPeerConnectionHandlerClient
+ , public ActiveScriptWrappable
, public ActiveDOMObject {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(RTCPeerConnection);
DEFINE_WRAPPERTYPEINFO();
@@ -151,8 +153,10 @@ public:
void suspend() override;
void resume() override;
void stop() override;
+
+ // ActiveScriptWrappable
// We keep the this object alive until either stopped or closed.
- bool hasPendingActivity() const override
+ bool hasPendingActivity() const final
{
return !m_closed && !m_stopped;
}

Powered by Google App Engine
This is Rietveld 408576698