third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/modules/filesystem/FileWriter.idl ('k') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

index 2f8127853d629ffffb8db751590991a4302245e8..7c75a91d620e4e15d2b3b629783d4cbf7bcec458 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

@@ -26,6 +26,7 @@

#ifndef IDBDatabase_h

#define IDBDatabase_h

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/modules/v8/UnionTypesModules.h"

#include "core/dom/ActiveDOMObject.h"

@@ -55,6 +56,7 @@ class ExecutionContext;

class MODULES_EXPORT IDBDatabase final

: public RefCountedGarbageCollectedEventTargetWithInlineData<IDBDatabase>

+ , public ActiveScriptWrappable

, public ActiveDOMObject {

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(IDBDatabase);

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(IDBDatabase);

@@ -90,8 +92,10 @@ public:

void onAbort(int64_t, DOMException*);

void onComplete(int64_t);

+ // ActiveScriptWrappable

+ bool hasPendingActivity() const final;

// ActiveDOMObject

- bool hasPendingActivity() const override;

void stop() override;

// EventTarget