third_party/WebKit/Source/modules/filesystem/FileWriter.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileWriter.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/modules/filesystem/DOMFileSystem.idl ('k') | third_party/WebKit/Source/modules/filesystem/FileWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/FileWriter.h

diff --git a/third_party/WebKit/Source/modules/filesystem/FileWriter.h b/third_party/WebKit/Source/modules/filesystem/FileWriter.h

index a2653a14e18c4b9b5238d733ade89fb21425bcb9..3747cc2a2f91a88319f91054e2e3c2a4af283af1 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileWriter.h

+++ b/third_party/WebKit/Source/modules/filesystem/FileWriter.h

@@ -31,6 +31,7 @@

#ifndef FileWriter_h

#define FileWriter_h

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "core/dom/ActiveDOMObject.h"

#include "core/dom/ExecutionContext.h"

#include "core/fileapi/FileError.h"

@@ -53,6 +54,7 @@ class FileWriter final

: public FileWriterBase

, public EventTargetWithInlineData

#endif

+ , public ActiveScriptWrappable

, public ActiveDOMObject

, public WebFileWriterClient {

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(FileWriterBase);

@@ -82,7 +84,9 @@ public:

// ActiveDOMObject

void stop() override;

- bool hasPendingActivity() const override;

+ // ActiveScriptWrappable

+ bool hasPendingActivity() const final;

// EventTarget

const AtomicString& interfaceName() const override;