Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
index fe3072f9102dc2d10baf71ab231ca462c375505b..3eaecd9cb6ca5292c137794c16d1455bd17281bd 100644
--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
@@ -31,6 +31,7 @@
#ifndef DOMFileSystem_h
#define DOMFileSystem_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/dom/ExecutionContext.h"
@@ -48,7 +49,7 @@ class BlobCallback;
class FileEntry;
class FileWriterCallback;
-class MODULES_EXPORT DOMFileSystem final : public DOMFileSystemBase, public ScriptWrappable, public ActiveDOMObject {
+class MODULES_EXPORT DOMFileSystem final : public DOMFileSystemBase, public ScriptWrappable, public ActiveScriptWrappable, public ActiveDOMObject {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMFileSystem);
public:
@@ -64,8 +65,8 @@ public:
void removePendingCallbacks() override;
void reportError(ErrorCallback*, FileError*) override;
- // ActiveDOMObject overrides.
- bool hasPendingActivity() const override;
+ // ActiveScriptWrappable overrides.
+ bool hasPendingActivity() const final;
void createWriter(const FileEntry*, FileWriterCallback*, ErrorCallback*);
void createFile(const FileEntry*, BlobCallback*, ErrorCallback*);

Powered by Google App Engine
This is Rietveld 408576698