third_party/WebKit/Source/core/workers/SharedWorker.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/SharedWorker.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp ('k') | third_party/WebKit/Source/core/workers/SharedWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/SharedWorker.h

diff --git a/third_party/WebKit/Source/core/workers/SharedWorker.h b/third_party/WebKit/Source/core/workers/SharedWorker.h

index 0bdc83e7cb0f44beb90c4be5516d288a59270691..f2a2abf6fc00ef162e8172be1e4d03fd446c3d8a 100644

--- a/third_party/WebKit/Source/core/workers/SharedWorker.h

+++ b/third_party/WebKit/Source/core/workers/SharedWorker.h

@@ -32,6 +32,7 @@

#ifndef SharedWorker_h

#define SharedWorker_h

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "core/CoreExport.h"

#include "core/workers/AbstractWorker.h"

#include "platform/Supplementable.h"

@@ -41,7 +42,7 @@ namespace blink {

class ExceptionState;

-class CORE_EXPORT SharedWorker final : public AbstractWorker, public HeapSupplementable<SharedWorker> {

+class CORE_EXPORT SharedWorker final : public AbstractWorker, public HeapSupplementable<SharedWorker>, public ActiveScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(SharedWorker);

public:

@@ -54,7 +55,7 @@ public:

void setIsBeingConnected(bool b) { m_isBeingConnected = b; }

- bool hasPendingActivity() const override;

+ bool hasPendingActivity() const final;

DECLARE_VIRTUAL_TRACE();