Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamReader.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/streams/ReadableStreamReader.h
diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamReader.h b/third_party/WebKit/Source/core/streams/ReadableStreamReader.h
index 8bd5f2c490211dfb440605c3945c569457532e46..2f913f6241ff7dd54419eedc37d9e9676a6e7445 100644
--- a/third_party/WebKit/Source/core/streams/ReadableStreamReader.h
+++ b/third_party/WebKit/Source/core/streams/ReadableStreamReader.h
@@ -5,6 +5,7 @@
#ifndef ReadableStreamReader_h
#define ReadableStreamReader_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptPromiseProperty.h"
#include "bindings/core/v8/ScriptValue.h"
@@ -24,7 +25,7 @@ class ScriptState;
// ReadableStreamReader corresponds to the same-name class in the Streams spec
// https://streams.spec.whatwg.org/.
-class CORE_EXPORT ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ActiveDOMObject {
+class CORE_EXPORT ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ActiveScriptWrappable, public ActiveDOMObject {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ReadableStreamReader);
public:
@@ -41,7 +42,7 @@ public:
void close();
void error();
- bool hasPendingActivity() const override;
+ bool hasPendingActivity() const final;
void stop() override;
DECLARE_TRACE();

Powered by Google App Engine
This is Rietveld 408576698