Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: third_party/WebKit/Source/core/page/EventSource.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/EventSource.h
diff --git a/third_party/WebKit/Source/core/page/EventSource.h b/third_party/WebKit/Source/core/page/EventSource.h
index 906fc85681c04cae87ca6bb12f591ccadbf9c07b..8dc2d7f15a37f6e34b37895c5fb2c0083df57bee 100644
--- a/third_party/WebKit/Source/core/page/EventSource.h
+++ b/third_party/WebKit/Source/core/page/EventSource.h
@@ -32,6 +32,7 @@
#ifndef EventSource_h
#define EventSource_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "core/loader/ThreadableLoader.h"
@@ -49,7 +50,7 @@ class EventSourceInit;
class ExceptionState;
class ResourceResponse;
-class CORE_EXPORT EventSource final : public RefCountedGarbageCollectedEventTargetWithInlineData<EventSource>, private ThreadableLoaderClient, public ActiveDOMObject, public EventSourceParser::Client {
+class CORE_EXPORT EventSource final : public RefCountedGarbageCollectedEventTargetWithInlineData<EventSource>, private ThreadableLoaderClient, public ActiveScriptWrappable, public ActiveDOMObject, public EventSourceParser::Client {
DEFINE_WRAPPERTYPEINFO();
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(EventSource);
USING_GARBAGE_COLLECTED_MIXIN(EventSource);
@@ -87,7 +88,8 @@ public:
// asynchronous events from the loader won't be invoked.
void stop() override;
- bool hasPendingActivity() const override;
+ // ActiveScriptWrappable
+ bool hasPendingActivity() const final;
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698