third_party/WebKit/Source/core/css/FontFace.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFace.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/core/animation/Animation.idl ('k') | third_party/WebKit/Source/core/css/FontFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontFace.h

diff --git a/third_party/WebKit/Source/core/css/FontFace.h b/third_party/WebKit/Source/core/css/FontFace.h

index d243d62f7a8f27eb7f6e0f313482c5999a402e6a..abef40649388488c7eb6ab6c47c05a1cc1f954d1 100644

--- a/third_party/WebKit/Source/core/css/FontFace.h

+++ b/third_party/WebKit/Source/core/css/FontFace.h

@@ -31,6 +31,7 @@

#ifndef FontFace_h

#define FontFace_h

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptPromiseProperty.h"

#include "bindings/core/v8/ScriptWrappable.h"

@@ -56,7 +57,7 @@ class StringOrArrayBufferOrArrayBufferView;

class StylePropertySet;

class StyleRuleFontFace;

-class FontFace : public RefCountedWillBeGarbageCollectedFinalized<FontFace>, public ScriptWrappable, public ActiveDOMObject {

+class FontFace : public RefCountedWillBeGarbageCollectedFinalized<FontFace>, public ScriptWrappable, public ActiveScriptWrappable, public ActiveDOMObject {

DEFINE_WRAPPERTYPEINFO();

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(FontFace);

public:

@@ -109,8 +110,8 @@ public:

};

void loadWithCallback(PassRefPtrWillBeRawPtr<LoadFontCallback>, ExecutionContext*);

- // ActiveDOMObject

- bool hasPendingActivity() const override;

+ // ActiveScriptWrappable.

+ bool hasPendingActivity() const final;

private:

static PassRefPtrWillBeRawPtr<FontFace> create(ExecutionContext*, const AtomicString& family, PassRefPtr<DOMArrayBuffer> source, const FontFaceDescriptors&);