third_party/WebKit/Source/core/animation/Animation.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.h

diff --git a/third_party/WebKit/Source/core/animation/Animation.h b/third_party/WebKit/Source/core/animation/Animation.h

index 4e8cf97e0398d95d8fe4622cd1984a0cb127c25e..05222b22b381bef1f03c9a95a71baeb1e1343ab4 100644

--- a/third_party/WebKit/Source/core/animation/Animation.h

+++ b/third_party/WebKit/Source/core/animation/Animation.h

@@ -31,6 +31,7 @@

#ifndef Animation_h

#define Animation_h

+#include "bindings/core/v8/ActiveScriptWrappable.h"

#include "bindings/core/v8/ExceptionStatePlaceholder.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptPromiseProperty.h"

@@ -54,6 +55,7 @@ class ExceptionState;

class CORE_EXPORT Animation final

: public RefCountedGarbageCollectedEventTargetWithInlineData<Animation>

+ , public ActiveScriptWrappable

, public ActiveDOMObject

, public CompositorAnimationDelegate

, public CompositorAnimationPlayerClient {

@@ -115,7 +117,7 @@ public:

const AtomicString& interfaceName() const override;

ExecutionContext* getExecutionContext() const override;

- bool hasPendingActivity() const override;

+ bool hasPendingActivity() const final;

void stop() override;

double playbackRate() const;