Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/Animation.h
diff --git a/third_party/WebKit/Source/core/animation/Animation.h b/third_party/WebKit/Source/core/animation/Animation.h
index 4e8cf97e0398d95d8fe4622cd1984a0cb127c25e..05222b22b381bef1f03c9a95a71baeb1e1343ab4 100644
--- a/third_party/WebKit/Source/core/animation/Animation.h
+++ b/third_party/WebKit/Source/core/animation/Animation.h
@@ -31,6 +31,7 @@
#ifndef Animation_h
#define Animation_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ExceptionStatePlaceholder.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptPromiseProperty.h"
@@ -54,6 +55,7 @@ class ExceptionState;
class CORE_EXPORT Animation final
: public RefCountedGarbageCollectedEventTargetWithInlineData<Animation>
+ , public ActiveScriptWrappable
, public ActiveDOMObject
, public CompositorAnimationDelegate
, public CompositorAnimationPlayerClient {
@@ -115,7 +117,7 @@ public:
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override;
- bool hasPendingActivity() const override;
+ bool hasPendingActivity() const final;
void stop() override;
double playbackRate() const;

Powered by Google App Engine
This is Rietveld 408576698