Fix CrWin7Goma(clbr) build.

Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

These are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299338

[shinyak, 2016-03-16 06:25:33]

Description was changed from

==========
Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

There are the copied DLLs.
- msvsp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882
==========

to

==========
Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

There are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882
==========

[shinyak, 2016-03-16 06:26:13]

shinyak@chromium.org changed reviewers:
+ brucedawson@chromium.org, phajdan.jr@chromium.org, shinyak@chromium.org,
ukai@chromium.org, yyanagisawa@chromium.org

[brucedawson, 2016-03-16 15:57:39]

Good fix, lgtm.

It is annoying how many places we have to list all of the necessary CRT run-time
DLLs. I hope they don't change the pattern again anytime soon.

[shinyak, 2016-03-17 02:17:53]

Description was changed from

==========
Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

There are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882
==========

to

==========
Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

These are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882
==========

[shinyak, 2016-03-17 02:18:47]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 02:18:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805833002/1

[commit-bot: I haz the power, 2016-03-17 02:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 02:22:25]

Dry run: This issue passed the CQ dry run.

[shinyak, 2016-03-17 02:28:33]

The CQ bit was checked by shinyak@chromium.org

[commit-bot: I haz the power, 2016-03-17 02:28:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805833002/1

[commit-bot: I haz the power, 2016-03-17 02:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 02:28:46]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[shinyak, 2016-03-17 02:30:50]

shinyak@chromium.org changed reviewers:
+ thakis@chromium.org
- phajdan.jr@chromium.org

[shinyak, 2016-03-17 02:31:24]

+thakis for OWNERS review

[Nico, 2016-03-17 02:48:22]

On 2016/03/17 02:31:24, shinyak wrote:
> +thakis for OWNERS review

Lgtm

[shinyak, 2016-03-17 03:49:37]

The CQ bit was checked by shinyak@chromium.org

[commit-bot: I haz the power, 2016-03-17 03:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805833002/1

[commit-bot: I haz the power, 2016-03-17 03:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 03:49:43]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[ukai, 2016-03-17 03:51:38]

lgtm

[Yoshisato Yanagisawa, 2016-03-17 03:54:30]

lgtm

[shinyak (Google), 2016-03-17 04:05:58]

The CQ bit was checked by shinyak@google.com

[commit-bot: I haz the power, 2016-03-17 04:06:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805833002/1

[commit-bot: I haz the power, 2016-03-17 04:10:01]

Description was changed from

==========
Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

These are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882
==========

to

==========
Fix CrWin7Goma(clbr) build.

Now VS2015 is the default compiler for Win. It requires several more
DLLs, and they're copied to out/{Debug,Release} directory in
'gclient runhooks' step.

These are the copied DLLs.
- msvcp140{,d}.dll
- vcruntime140{,d}.dll
- api-ms-win-*.dll
- ucrtbase{,d}.dll

However, compile.py removes them if --clobber is specified.

Win builder on main waterfall should have the same potential problem,
however, it is not affected because it's not building net_unittests.
CrWin7Goma(clbr) is affected because it builds all.

BUG=594882

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299338
==========

[commit-bot: I haz the power, 2016-03-17 04:10:02]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299338