[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL https://codereview.chromium.org/1782713003/
I submitted a few days ago was still wrong.
This time a test is also added.

Committed: https://crrev.com/e886edbb2d3d7eade99d9542b56dfc9a7701248f
Cr-Commit-Position: refs/heads/master@{#381523}

[trchen, 2016-03-16 03:21:56]

Description was changed from

==========
[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL I submitted a few days ago was still wrong.
This time a test is also added.
==========

to

==========
[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL https://codereview.chromium.org/1782713003/
I submitted a few days ago was still wrong.
This time a test is also added.
==========

[trchen, 2016-03-16 03:30:06]

trchen@chromium.org changed reviewers:
+ jbroman@chromium.org, pdr@chromium.org

[trchen, 2016-03-16 03:30:07]

I swear I will always write a test no matter how trivial the change may seem.
(insert shame cube meme here)

Turns out gfx::Transform uses a convention for operation ordering that is
opposite from Skia.
transform.Translate(x, y) actually means
transform.PreConcatTransform(translateXY)

[trchen, 2016-03-16 03:31:12]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 03:31:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805823002/1

[commit-bot: I haz the power, 2016-03-16 05:20:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 05:20:44]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-03-16 17:53:11]

lgtm

Are there any layout tests that are improved by this fix?

[pdr., 2016-03-16 20:01:18]

On 2016/03/16 at 17:53:11, jbroman wrote:
> lgtm
> 
> Are there any layout tests that are improved by this fix?

Could you check if there are any new layout test passes? That's sort of a proof
that this works end-to-end.

[trchen, 2016-03-16 20:33:27]

On 2016/03/16 20:01:18, pdr wrote:
> On 2016/03/16 at 17:53:11, jbroman wrote:
> > lgtm
> > 
> > Are there any layout tests that are improved by this fix?
> 
> Could you check if there are any new layout test passes? That's sort of a
proof
> that this works end-to-end.

There are two layout tests that are converted into sub-pixel failures. They are
both currently tracked under a different crbug#.

[trchen, 2016-03-16 20:33:55]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2016-03-16 20:34:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805823002/1

[commit-bot: I haz the power, 2016-03-16 20:42:57]

Description was changed from

==========
[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL https://codereview.chromium.org/1782713003/
I submitted a few days ago was still wrong.
This time a test is also added.
==========

to

==========
[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL https://codereview.chromium.org/1782713003/
I submitted a few days ago was still wrong.
This time a test is also added.
==========

[commit-bot: I haz the power, 2016-03-16 20:42:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-16 20:44:38]

Description was changed from

==========
[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL https://codereview.chromium.org/1782713003/
I submitted a few days ago was still wrong.
This time a test is also added.
==========

to

==========
[SPv2] Fix PaintArtifactCompositor clip layer origin undo order

The CL https://codereview.chromium.org/1782713003/
I submitted a few days ago was still wrong.
This time a test is also added.

Committed: https://crrev.com/e886edbb2d3d7eade99d9542b56dfc9a7701248f
Cr-Commit-Position: refs/heads/master@{#381523}
==========

[commit-bot: I haz the power, 2016-03-16 20:44:39]

Patchset 1 (id:??) landed as
https://crrev.com/e886edbb2d3d7eade99d9542b56dfc9a7701248f
Cr-Commit-Position: refs/heads/master@{#381523}