[Media Router] Wiring for searching route providers for new sinks.

chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
index eddec3cfbc703d31940a743e85dabccc8bb0e868..e14f5c40f72dd9a43c99aab53fee02601998008a 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
@@ -1043,6 +1043,26 @@ Polymer({
   },
 
   /**
+   * Creates a sink for the search result list whose name is equal to the
+   * currently entered search text. This sink will create a new hangout sink if
+   * the user clicks it.
+   * @param {string} name Name of the new hangout.

[amp, 2016/03/16 17:20:12]

Can we include the domain here as well (it should have been passed in to the
container.

[btolsch, 2016/03/16 18:36:30]

Done.

+   * @return {!{sinkItem: !media_router.Sink,
+   *           substrings: Array<!Array<number>>}} A search result item that
+   *     indicates a new hangout named |name| can be created.
+   */
+  createManualHangoutItem_: function(name) {
+    return {
+      sinkItem: new media_router.Sink(null, name, 'Add hangout', null,
+          media_router.SinkIconType.HANGOUT,
+          media_router.SinkStatus.IDLE,
+          media_router.CastModeType.TAB_MIRROR |
+              media_router.CastModeType.DESKTOP_MIRROR),
+      substrings: [[0, name.length - 1]],
+    };
+  },
+
+  /**
    * Filters all sinks based on fuzzy matching to the currently entered search
    * text.
    * @param {string} searchInputText The currently entered search text.
@@ -1069,6 +1089,7 @@ Polymer({
                                 substrings: matchSubstrings});
     }
     searchResultsToShow.sort(this.compareSearchMatches_);
+    searchResultsToShow.unshift(this.createManualHangoutItem_(searchInputText));

[amp, 2016/03/16 17:20:12]

Do we need to tie this into the mrps better somehow?  Something like have the
mrp's send back a signal that they support searching for sinks (maybe send back
a psuedo sink with the correct icon type etc) and then use that to add in a
search result entry that would actually trigger the search?

This would definitely work, but it feels too tightly tied to Hangouts (which the
UI ideally would know nothing about).

[btolsch, 2016/03/16 18:36:30]

I like this idea. I'm not sure there's a good way to add this within the current
sink structure though. I could see each MRP having a special sink id and/or
having a dummy cast mode.  I think these both have problems with forward
compatibility though. Do you have an idea of how best to include this?

     this.searchResultsToShow_ = searchResultsToShow;
   },
 
@@ -1294,7 +1315,17 @@ Polymer({
     var clickedSink = (this.isUserSearching_) ?
         this.$$('#searchResults').itemForElement(event.target).sinkItem :
         this.$.sinkList.itemForElement(event.target);
-    this.showOrCreateRoute_(clickedSink);
+    if (!clickedSink.id) {
+      this.fire('add-hangout', {

[amp, 2016/03/16 17:20:12]

maybe use a more generic name instead of referring to hangouts specifically.

[btolsch, 2016/03/16 18:36:30]

I like the idea of pseudo sinks from the MRP's, and that would also get rid of
this mechanism. If we stay with this mechanism, I will rename it though.

+        name: clickedSink.name,
+        selectedCastMode:
+            this.shownCastModeValue_ == media_router.CastModeType.AUTO ?
+                clickedSink.castModes & -clickedSink.castModes :
+                this.shownCastModeValue_
+      });
+    } else {
+      this.showOrCreateRoute_(clickedSink);

[amp, 2016/03/16 17:20:12]

I don't see where we do the route creation for the newly added sink.  Is that in
a coming patch/change?

Ideally clicking on a one of these pending sinks should start the spinner (same
as if a route was being created) and keep spinning until 1. the sink has been
searched with the provider and 2. the route from the source to this sink has
been created.

[btolsch, 2016/03/16 18:36:30]

That will depend on what happens with the rest of the API because as it stands
now, this doesn't seem to work for hangouts. The first one (or more?)
create-route events on the hangout, even once it makes it from the MRP to the
UI, fails silently.  The cloud MRP rejects routing the sink for a short period,
even though it effectively created it. I think other changes will help address
this but we can talk offline about whether anything needs to change in the
extension to support this.

+    }
     this.fire('sink-click', {index: event['model'].index});
   },