 Chromium Code Reviews
 Chromium Code Reviews Issue 18058008:
  CPUProfiler: Improve line numbers support in profiler.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 18058008:
  CPUProfiler: Improve line numbers support in profiler.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/compiler.cc | 
| diff --git a/src/compiler.cc b/src/compiler.cc | 
| index 221639e232c97d35659e0f50b44c970dabc5a239..7497f09d51979e50091d47b03e0523433d39168c 100644 | 
| --- a/src/compiler.cc | 
| +++ b/src/compiler.cc | 
| @@ -1200,9 +1200,9 @@ void Compiler::RecordFunctionCompilation(Logger::LogEventsAndTags tag, | 
| Handle<Code> code = info->code(); | 
| if (*code == info->isolate()->builtins()->builtin(Builtins::kLazyCompile)) | 
| return; | 
| + int line_num = GetScriptLineNumber(script, shared->start_position()) + 1; | 
| + USE(line_num); | 
| 
yurys
2013/07/06 05:03:22
It seems that you can drop this line as line_num i
 | 
| if (script->name()->IsString()) { | 
| - int line_num = GetScriptLineNumber(script, shared->start_position()) + 1; | 
| - USE(line_num); | 
| PROFILE(info->isolate(), | 
| CodeCreateEvent(Logger::ToNativeByScript(tag, *script), | 
| *code, | 
| @@ -1216,7 +1216,8 @@ void Compiler::RecordFunctionCompilation(Logger::LogEventsAndTags tag, | 
| *code, | 
| *shared, | 
| info, | 
| - shared->DebugName())); | 
| + info->isolate()->heap()->empty_string(), | 
| + line_num)); | 
| } | 
| } |