CPUProfiler: Improve line numbers support in profiler.

src/cpu-profiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 136 matching lines @@
 };
 
 
 // This class implements both the profile events processor thread and
 // methods called by event producers: VM and stack sampler threads.
 class ProfilerEventsProcessor : public Thread {
  public:
   explicit ProfilerEventsProcessor(ProfileGenerator* generator);
   virtual ~ProfilerEventsProcessor() {}
 
+  // Processes all code events and starts the thread.
+  void Start();

[yurys, 2013/07/05 13:10:00]

There is already non-virtual method Start in Thread class.

[loislo, 2013/07/05 13:15:37]

reverted

+
   // Thread control.
   virtual void Run();
-  inline void Stop() { running_ = false; }
+  void Stop();
   INLINE(bool running()) { return running_; }
   void Enqueue(const CodeEventsContainer& event);
 
   // Puts current stack into tick sample events buffer.
   void AddCurrentStack(Isolate* isolate);
 
   // Tick sample events are filled directly in the buffer of the circular
   // queue (because the structure is of fixed width, but usually not all
   // stack frame entries are filled.) This method returns a pointer to the
   // next record of the buffer.
   INLINE(TickSample* TickSampleEvent());
 
  private:
   // Called from events processing thread (Run() method.)
-  bool ProcessCodeEvent(unsigned* dequeue_order);
-  bool ProcessTicks(unsigned dequeue_order);
+  bool ProcessCodeEvent();
+  bool ProcessTicks();
 
   ProfileGenerator* generator_;
   bool running_;
   UnboundQueue<CodeEventsContainer> events_buffer_;
   SamplingCircularQueue ticks_buffer_;
   UnboundQueue<TickSampleEventRecord> ticks_from_vm_buffer_;
-  unsigned enqueue_order_;
+  unsigned last_recorded_code_event_id_;

[yurys, 2013/07/05 13:10:00]

last_code_event_id_

[loislo, 2013/07/05 13:15:37]

Done.

+  unsigned last_processed_code_event_id_;
 };
 
 
 #define PROFILE(IsolateGetter, Call)                                   \
   do {                                                                 \
     Isolate* cpu_profiler_isolate = (IsolateGetter);                   \
     LOG_CODE_EVENT(cpu_profiler_isolate, Call);                        \
     CpuProfiler* cpu_profiler = cpu_profiler_isolate->cpu_profiler();  \
     if (cpu_profiler->is_profiling()) {                                \
       cpu_profiler->Call;                                              \
@@ skipping 51 matching lines @@
   void GetterCallbackEvent(Name* name, Address entry_point);
   void RegExpCodeCreateEvent(Code* code, String* source);
   void SetterCallbackEvent(Name* name, Address entry_point);
   void SharedFunctionInfoMoveEvent(Address from, Address to);
 
   INLINE(bool is_profiling() const) { return is_profiling_; }
   bool* is_profiling_address() {
     return &is_profiling_;
   }
 
+  ProfileGenerator* generator() const { return generator_; }
+  ProfilerEventsProcessor* processor() const { return processor_; }
+
  private:
   void StartProcessorIfNotStarted();
   void StopProcessorIfLastProfile(const char* title);
   void StopProcessor();
   void ResetProfiles();
   void LogBuiltins();
 
   Isolate* isolate_;
   CpuProfilesCollection* profiles_;
   unsigned next_profile_uid_;
   TokenEnumerator* token_enumerator_;
   ProfileGenerator* generator_;
   ProfilerEventsProcessor* processor_;
   int saved_logging_nesting_;
   bool need_to_stop_sampler_;
   bool is_profiling_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CpuProfiler);
 };
 
 } }  // namespace v8::internal
 
 
 #endif  // V8_CPU_PROFILER_H_