Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/compiler.cc

Issue 18058008: CPUProfiler: Improve line numbers support in profiler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/cpu-profiler.h » ('j') | src/cpu-profiler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 1192
1193 // Log the code generation. If source information is available include 1193 // Log the code generation. If source information is available include
1194 // script name and line number. Check explicitly whether logging is 1194 // script name and line number. Check explicitly whether logging is
1195 // enabled as finding the line number is not free. 1195 // enabled as finding the line number is not free.
1196 if (info->isolate()->logger()->is_logging_code_events() || 1196 if (info->isolate()->logger()->is_logging_code_events() ||
1197 info->isolate()->cpu_profiler()->is_profiling()) { 1197 info->isolate()->cpu_profiler()->is_profiling()) {
1198 Handle<Script> script = info->script(); 1198 Handle<Script> script = info->script();
1199 Handle<Code> code = info->code(); 1199 Handle<Code> code = info->code();
1200 if (*code == info->isolate()->builtins()->builtin(Builtins::kLazyCompile)) 1200 if (*code == info->isolate()->builtins()->builtin(Builtins::kLazyCompile))
1201 return; 1201 return;
1202 int line_num = GetScriptLineNumber(script, shared->start_position()) + 1;
1203 USE(line_num);
1202 if (script->name()->IsString()) { 1204 if (script->name()->IsString()) {
1203 int line_num = GetScriptLineNumber(script, shared->start_position()) + 1;
1204 USE(line_num);
1205 PROFILE(info->isolate(), 1205 PROFILE(info->isolate(),
1206 CodeCreateEvent(Logger::ToNativeByScript(tag, *script), 1206 CodeCreateEvent(Logger::ToNativeByScript(tag, *script),
1207 *code, 1207 *code,
1208 *shared, 1208 *shared,
1209 info, 1209 info,
1210 String::cast(script->name()), 1210 String::cast(script->name()),
1211 line_num)); 1211 line_num));
1212 } else { 1212 } else {
1213 PROFILE(info->isolate(), 1213 PROFILE(info->isolate(),
1214 CodeCreateEvent(Logger::ToNativeByScript(tag, *script), 1214 CodeCreateEvent(Logger::ToNativeByScript(tag, *script),
1215 *code, 1215 *code,
1216 *shared, 1216 *shared,
1217 info, 1217 info,
1218 shared->DebugName())); 1218 info->isolate()->heap()->empty_string(),
1219 line_num));
1219 } 1220 }
1220 } 1221 }
1221 1222
1222 GDBJIT(AddCode(Handle<String>(shared->DebugName()), 1223 GDBJIT(AddCode(Handle<String>(shared->DebugName()),
1223 Handle<Script>(info->script()), 1224 Handle<Script>(info->script()),
1224 Handle<Code>(info->code()), 1225 Handle<Code>(info->code()),
1225 info)); 1226 info));
1226 } 1227 }
1227 1228
1228 1229
(...skipping 17 matching lines...) Expand all
1246 1247
1247 1248
1248 bool CompilationPhase::ShouldProduceTraceOutput() const { 1249 bool CompilationPhase::ShouldProduceTraceOutput() const {
1249 // Produce trace output if flag is set so that the first letter of the 1250 // Produce trace output if flag is set so that the first letter of the
1250 // phase name matches the command line parameter FLAG_trace_phase. 1251 // phase name matches the command line parameter FLAG_trace_phase.
1251 return (FLAG_trace_hydrogen && 1252 return (FLAG_trace_hydrogen &&
1252 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1253 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1253 } 1254 }
1254 1255
1255 } } // namespace v8::internal 1256 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/cpu-profiler.h » ('j') | src/cpu-profiler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698