Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1805773002: Disable FontName, FontSize, and FontSizeDelta commands in contenteditable=plaintext-only. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable FontName, FontSize, and FontSizeDelta commands in contenteditable=plaintext-only. We shouldn't add <font> elements to plain-text editors. BUG=594917 TEST=automated Committed: https://crrev.com/0905ff8febc72c69c471e9c5035caa62cfc171e8 Cr-Commit-Position: refs/heads/master@{#381406}

Patch Set 1 #

Patch Set 2 : Fix fast/forms/plaintext-mode-1.html #

Messages

Total messages: 17 (8 generated)
tkent
yosin@, would you review this please?
4 years, 9 months ago (2016-03-16 00:55:32 UTC) #2
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-16 01:06:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805773002/1
4 years, 9 months ago (2016-03-16 01:06:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/197130)
4 years, 9 months ago (2016-03-16 02:05:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805773002/20001
4 years, 9 months ago (2016-03-16 02:21:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157451)
4 years, 9 months ago (2016-03-16 02:31:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805773002/20001
4 years, 9 months ago (2016-03-16 03:06:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 05:39:19 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 05:40:58 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0905ff8febc72c69c471e9c5035caa62cfc171e8
Cr-Commit-Position: refs/heads/master@{#381406}

Powered by Google App Engine
This is Rietveld 408576698